[FLINK-6246] Fix generic type of OutputTag in operator Output#3662
Closed
aljoscha wants to merge 2 commits intoapache:masterfrom
Closed
[FLINK-6246] Fix generic type of OutputTag in operator Output#3662aljoscha wants to merge 2 commits intoapache:masterfrom
aljoscha wants to merge 2 commits intoapache:masterfrom
Conversation
aljoscha
force-pushed
the
jira-6246-fix-output-tag-param
branch
from
3cfc5b1 to
7d1e656
Compare
aljoscha
changed the title
dawidwys
reviewed
Apr 3, 2017
|
|
||
| // due to side outputs, StreamRecords of varying types can pass through the broadcasting | ||
| // collector so we need to cast | ||
| @SuppressWarnings({"unchecked", "rawtypes"}) |
Contributor
There was a problem hiding this comment.
Suppression not needed anymore. Also the comment is not adequate, as we do not cast anything.
| } | ||
|
|
||
| // don't copy for the last output | ||
| @SuppressWarnings({"unchecked", "rawtypes"}) |
|
|
||
| // execute the program | ||
| env.execute("Streaming Iteration Example"); | ||
| System.out.println(env.getExecutionPlan()); |
Contributor
There was a problem hiding this comment.
I think this change should be reverted.
Contributor
Author
There was a problem hiding this comment.
Oh no, I was playing around with something. 😱
Contributor
Author
|
@dawidwys thanks for reviewing so quickly. I pushed a commit to address your comments. |
Contributor
|
Now, I think it is good to merge ;) |
Contributor
|
merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @dawidwys