[FLINK-6326] [table] add ProjectMergeRule at logical optimization stage #3739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhueske
reviewed
Apr 19, 2017
Contributor
fhueske
left a comment
fhueske
left a comment
There was a problem hiding this comment.
Thanks for this PR @godfreyhe!
I think the PR is good, but I would remove the explain test. The other plan tests are sufficient to validate that the desired plans are generated.
Thanks, Fabian
| } | ||
|
|
||
| @Test | ||
| def testProjectMerge(): Unit = { |
Contributor
There was a problem hiding this comment.
I don't think we need to add a test to ExplainTest.scala. The other plan tests are sufficient to validate that the desired plans are generated.
| @@ -0,0 +1,156 @@ | |||
| == Abstract Syntax Tree == | |||
Contributor
There was a problem hiding this comment.
This file can be removed, IMO.
Contributor
|
Merging |
StefanRRichter
pushed a commit
to StefanRRichter/flink
that referenced
this pull request
Apr 24, 2017
…e set. This closes apache#3739.
PangZhi
pushed a commit
to PangZhi/flink
that referenced
this pull request
May 1, 2017
…e set. This closes apache#3739.
StefanRRichter
pushed a commit
to StefanRRichter/flink
that referenced
this pull request
May 5, 2017
…e set. This closes apache#3739.
fanyon
pushed a commit
to fanyon/flink
that referenced
this pull request
May 11, 2017
…e set. This closes apache#3739.
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
…e set. This closes apache#3739.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ProjectMergeRule to merge projections