[FLINK-6411] [flip-6] Remove job removal from RunningJobsRegistry in YarnFlinkApplicationMasterRunner.shutdown#3797
Closed
tillrohrmann wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
…YarnFlinkApplicationMasterRunner.shutdown The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from the RunningJobsRegistry. This is the responsibility of the JobManagerRunner. This PR removes the job removal from the RunningJobRegistry from the YarnFlinkApplicationMasterRunner.shutdown method.
Contributor
Author
|
Merging this PR since changes are trivial and Travis gave green light. |
fanyon
pushed a commit
to fanyon/flink
that referenced
this pull request
May 11, 2017
…YarnFlinkApplicationMasterRunner.shutdown The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from the RunningJobsRegistry. This is the responsibility of the JobManagerRunner. This PR removes the job removal from the RunningJobRegistry from the YarnFlinkApplicationMasterRunner.shutdown method. This closes apache#3797.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The YarnFlinkApplicationMasterRunner should not be concerned with removing jobs from
the RunningJobsRegistry. This is the responsibility of the JobManagerRunner.
This PR removes the job removal from the RunningJobRegistry from the
YarnFlinkApplicationMasterRunner.shutdown method.