[FLINK-6512][docs] improved code formatting in some examples #3857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@alpinegizmo is there a standard use here for tabs and spaces? This looks to assume that 1 tab = 8 spaces. If tabs are forcing too large and indentation why not use spaces everyone? |
Contributor
Author
|
@greghogan Yes, I think we should use spaces rather than tabs in code samples in the docs -- and fewer than 8. I looked around at all of the code in the docs, and made sure that all of it is now inside of a code highlighting block. I only changed indentation in cases where it really bothered me. Making the indentation 100% consistent didn't seem worth the trouble, and wouldn't very enforceable going forward (unless the highlight plugin is capable of doing the indentation for us). |
Contributor
|
@alpinegizmo changes look good. Merging ... |
asfgit
pushed a commit
that referenced
this pull request
May 10, 2017
asfgit
pushed a commit
that referenced
this pull request
May 10, 2017
StefanRRichter
pushed a commit
to StefanRRichter/flink
that referenced
this pull request
May 11, 2017
StefanRRichter
pushed a commit
to StefanRRichter/flink
that referenced
this pull request
May 12, 2017
StefanRRichter
pushed a commit
to StefanRRichter/flink
that referenced
this pull request
May 12, 2017
fanyon
pushed a commit
to fanyon/flink
that referenced
this pull request
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.