[FLINK-6536] [cep] Improve error message in SharedBuffer::put(). #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljoscha
approved these changes
May 11, 2017
Contributor
aljoscha
left a comment
aljoscha
left a comment
There was a problem hiding this comment.
LGTM once Travis says it's green! 👍
| previousTimestamp + ". This can indicate that the element belonging to the previous " + | ||
| "relation has been already pruned, even though you expect it to be still there."); | ||
| previousTimestamp + ". This can indicate that either you did not implement " + | ||
| "the equals() and hashCode() methods, of your input elements properly or that " + |
Contributor
There was a problem hiding this comment.
I think the comma is superfluous.
dawidwys
reviewed
May 15, 2017
| "relation has been already pruned, even though you expect it to be still there."); | ||
| previousTimestamp + ". This can indicate that either you did not implement " + | ||
| "the equals() and hashCode() methods of your input elements properly or that " + | ||
| "the element belonging to that entry has been already pruned."); |
Contributor
There was a problem hiding this comment.
Been thinking about this exception message and those two reasons for the exception come from "two different worlds".
- if element has been pruned - from user perspective this means some error in CEP library occured and the user can not do much about it.
- the equals() and hashCode() are obvious user mistakes.
Not sure if we should do sth with it, but just wanted to express my thoughts on it.
Contributor
Author
There was a problem hiding this comment.
You are right @dawidwys but I think that now the message makes clear that you should always implement equals() and hashCode(). So far it was only in the docs.
Contributor
Author
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits that address both FLINK-6536 and FLINK-6255.
R @aljoscha