[FLINK-6517] [table] Support multiple consecutive windows #3897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhueske
reviewed
May 15, 2017
| override private[flink] def validateInput(): ValidationResult = { | ||
| child match { | ||
| case WindowReference(_, Some(tpe)) if !isRowtimeIndicatorType(tpe) => | ||
| ValidationFailure("A proctime window can not guarantee a rowtime attribute.") |
Contributor
There was a problem hiding this comment.
-> "A proctime window cannot provide a rowtime attribute"?
| } | ||
|
|
||
| private[flink] def toNamedWindowProperty(name: String)(implicit relBuilder: RelBuilder) | ||
| def toNamedWindowProperty(name: String) |
| import org.apache.flink.table.utils.TableTestBase | ||
| import org.apache.flink.table.utils.TableTestUtil._ | ||
| import org.junit.Test | ||
| import org.junit.{Ignore, Test} |
| import org.apache.flink.types.Row | ||
| import org.junit.Assert._ | ||
| import org.junit.Test | ||
| import org.junit.{Ignore, Test} |
Contributor
Author
|
Thanks for the review @fhueske. I will merge this... |
asfgit
pushed a commit
that referenced
this pull request
May 15, 2017
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple consecutive windows for the Table API. SQL requires additional group auxiliary functions. I will open a followup issue for that.