[FLINK-6578] Fix self-loop handling in SharedBuffer. #3909
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kl0u
force-pushed
the
cep-uber-pr
branch
3 times, most recently
from
1215346 to
0fdcd37
Compare
dawidwys
reviewed
May 16, 2017
| } | ||
|
|
||
| /** | ||
| * Extracts all the sequences of events from the start to the given computation state. An event |
Contributor
There was a problem hiding this comment.
With the Preconditions.checkState(paths.size() <= 1); all = 1
| * @param version Version of the previous relation | ||
| */ | ||
| public void put( | ||
| public int put( |
Contributor
There was a problem hiding this comment.
missing javadoc for return
| * @param version Version of the previous relation | ||
| */ | ||
| public void put( | ||
| public int put( |
Contributor
There was a problem hiding this comment.
missing javadoc for return
| */ | ||
| public void lock(final K key, final V value, final long timestamp) { | ||
| SharedBufferEntry<K, V> entry = get(key, value, timestamp); | ||
| public void lock(final K key, final V value, final long timestamp, int counter) { |
Contributor
There was a problem hiding this comment.
missing javadoc for counter
| */ | ||
| public void release(final K key, final V value, final long timestamp) { | ||
| SharedBufferEntry<K, V> entry = get(key, value, timestamp); | ||
| public void release(final K key, final V value, final long timestamp, int counter) { |
Contributor
There was a problem hiding this comment.
missing javadoc for counter
kl0u
force-pushed
the
cep-uber-pr
branch
6 times, most recently
from
ff965e8 to
e01659b
Compare
Contributor
Author
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RP addresses: FLINK-6604, FLINK-6371, FLINK-6536, FLINK-6255, and FLINK-6578.
R @dawidwys