[FLINK-6431] [metrics] Activate strict checkstyle in flink-metrics#3968
Closed
zentol wants to merge 3 commits intoapache:masterfrom
Closed
[FLINK-6431] [metrics] Activate strict checkstyle in flink-metrics#3968zentol wants to merge 3 commits intoapache:masterfrom
zentol wants to merge 3 commits intoapache:masterfrom
Conversation
greghogan
reviewed
May 23, 2017
| } | ||
|
|
||
| /** | ||
| * Given "<xxx>", return "xxx" |
Contributor
There was a problem hiding this comment.
Could be helpful to leave a comment noting the removal of the leading and trailing angle brackets.
| <configuration> | ||
| <configLocation>../tools/maven/strict-checkstyle.xml</configLocation> | ||
| <suppressionsLocation>../tools/maven/suppressions.xml</suppressionsLocation> | ||
| <logViolationsToConsole>true</logViolationsToConsole> |
Contributor
There was a problem hiding this comment.
includeTestSourceDirectory?
flink-metrics/pom.xml
Outdated
| </dependency> | ||
| </dependencies> | ||
| <configuration> | ||
| <configLocation>../tools/maven/strict-checkstyle.xml</configLocation> |
Contributor
There was a problem hiding this comment.
Use "absolute" paths as flink-streaming-java?
Contributor
Author
There was a problem hiding this comment.
huh, I'm surprised that the configuration in streaming-java actually works.
Contributor
Author
|
I've included the sources, change the path and added the removed comment. Moving on to the other 2 checkstyle PRs... |
Contributor
|
+1 to merge after Travis gives the green light. |
Contributor
Author
|
merging. |
zentol
added a commit
to zentol/flink
that referenced
this pull request
May 24, 2017
zentol
added a commit
to zentol/flink
that referenced
this pull request
May 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.