[FLINK-6038][docs] Added deep links to Bahir connectors #3975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentol
reviewed
May 24, 2017
docs/dev/connectors/index.md
Outdated
|
|
||
| The [Apache Bahir](http://bahir.apache.org/) project provides some additional streaming connectors for Flink, including: | ||
|
|
||
| * [Apache ActiveMQ](http://bahir.apache.org/docs/flink/current/flink-streaming-activemq/) (sink/source) |
docs/dev/connectors/index.md
Outdated
| The [Apache Bahir](http://bahir.apache.org/) project provides some additional streaming connectors for Flink, including: | ||
|
|
||
| * [Apache ActiveMQ](http://bahir.apache.org/docs/flink/current/flink-streaming-activemq/) (sink/source) | ||
| * [Apache Flume](http://bahir.apache.org/docs/flink/current/flink-streaming-flume/) (sink) |
greghogan
reviewed
May 24, 2017
docs/dev/connectors/index.md
Outdated
|
|
||
| ## Connectors in Apache Bahir | ||
|
|
||
| The [Apache Bahir](https://bahir.apache.org/) project provides some additional streaming connectors for Flink, including: |
Contributor
There was a problem hiding this comment.
Remove "some". Consider reversing and expanding the statement, something like "Additional streaming connectors for Flink are being released through Apache Bahir, including:". This could help acclimate contributors and treats Bahir less like a third-party.
Contributor
|
@alpinegizmo thanks for the contribution! Merging ... |
asfgit
pushed a commit
that referenced
this pull request
Jun 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a section to the connectors overview page that lists the connectors in Bahir, with links to the docs for each.