[FLINK-7074] [tm] Add entry point for the TaskManagerRunner #4252
Conversation
The entry point can be used by the standalone mode to run a TaskManager. Moreover, the YarnTaskExecutorRunner now reuses some of the start up logic of the TaskManagerRunner.
flink-runtime/pom.xml
Outdated
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>org.slf4j</groupId> |
There was a problem hiding this comment.
IIRC we explicitly removed these dependencies so that other logging frameworks can be plugged in.
There was a problem hiding this comment.
The problem I had was that I couldn't start the TaskManagerRunner#main from within Intellij, because the class org.apache.log4j.Level could not be found. If I'm not mistaken, then we filter out the log4j dependencies when building the dist packages.
There was a problem hiding this comment.
I found a solution by manually setting the dependencies to scope compile within IntelliJ. For the others who run into the same problem you can do this under: Project structure --> Modules --> Dependency tab.
There was a problem hiding this comment.
For the sake of completeness, here is also the corresponding IntelliJ issue: https://youtrack.jetbrains.com/issue/IDEA-107048
|
Thanks for the review @zentol. I addressed your comment. Merging this PR. |
|
but....I didn't make a full review. I just scanned over it and found the oddity in the dependency... |
3 participants
The entry point can be used by the standalone mode to run a TaskManager. Moreover, the
YarnTaskExecutorRunner now reuses some of the start up logic of the TaskManagerRunner.