Skip to content

Conversation

@andralungu
Copy link
Contributor

No description provided.

@fhueske
Copy link
Contributor

fhueske commented Feb 20, 2015

Btw, you can update a PR by pushing into your remote branch and don't need to close and open a new PR. If you want to change previous commits (including commit message) or rebase the PR, you can do a "force push".
However, when doing a force push all code comments get lost, so you should avoid that if somebody reviewed the code and made comments.

@andralungu
Copy link
Contributor Author

Thank you for the tip! I am still learning the dirty insights of Git :) Next time I will just update the PR.

@vasia
Copy link
Contributor

vasia commented Mar 4, 2015

This looks good! Thanks @andralungu for catching the bug ^^
I'll merge it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants