Skip to content

[FLINK-7186] Activate checkstyle flink-java/sampling#4339

Closed
dawidwys wants to merge 1 commit intoapache:masterfrom
dawidwys:checkstyle-java-sampling
Closed

[FLINK-7186] Activate checkstyle flink-java/sampling#4339
dawidwys wants to merge 1 commit intoapache:masterfrom
dawidwys:checkstyle-java-sampling

Conversation

@dawidwys
Copy link
Copy Markdown
Contributor

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@zentol
Copy link
Copy Markdown
Contributor

zentol commented Jul 14, 2017

+1.

I'm wondering if we should beef up the tools/maven/suppressions-java.xml file to have suppressions per package like flink-runtime, and remove an entry in each PR. Just as a safety precaution in case we don't get this done in a timely manner, to prevent new violations being added.

@zentol
Copy link
Copy Markdown
Contributor

zentol commented Jul 18, 2017

merging.

@asfgit asfgit closed this in 72678f1 Jul 18, 2017
@dawidwys dawidwys deleted the checkstyle-java-sampling branch July 25, 2017 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants