Skip to content

[FLINK-7184] Activate checkstyle flink-java/hadoop#4341

Closed
dawidwys wants to merge 2 commits intoapache:masterfrom
dawidwys:checkstyle-java-hadoop
Closed

[FLINK-7184] Activate checkstyle flink-java/hadoop#4341
dawidwys wants to merge 2 commits intoapache:masterfrom
dawidwys:checkstyle-java-hadoop

Conversation

@dawidwys
Copy link
Copy Markdown
Contributor

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

Copy link
Copy Markdown
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment, otherwise +1

RecordWriter<String, Long> recordWriter,
OutputCommitter outputCommitter,
Configuration configuration) {
Job job,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's fix this indentation.

@zentol
Copy link
Copy Markdown
Contributor

zentol commented Jul 18, 2017

merging.

zentol pushed a commit to zentol/flink that referenced this pull request Jul 18, 2017
@asfgit asfgit closed this in 0fd492c Jul 18, 2017
@dawidwys dawidwys deleted the checkstyle-java-hadoop branch July 25, 2017 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants