[FLINK-7181] Activate checkstyle flink-java/operators/*#4342
Closed
dawidwys wants to merge 3 commits intoapache:masterfrom
Closed
[FLINK-7181] Activate checkstyle flink-java/operators/*#4342dawidwys wants to merge 3 commits intoapache:masterfrom
dawidwys wants to merge 3 commits intoapache:masterfrom
Conversation
NicoK
reviewed
Jul 18, 2017
| CoGroupRawOperatorBase<I1, I2, OUT, CoGroupFunction<I1, I2, OUT>> po | ||
| = new CoGroupRawOperatorBase<I1, I2, OUT, CoGroupFunction<I1, I2, OUT>>( | ||
| function, new BinaryOperatorInformation<I1, I2, OUT>(getInput1Type(), getInput2Type(), | ||
| CoGroupRawOperatorBase<I1, I2, OUT, CoGroupFunction<I1, I2, OUT>> po = new CoGroupRawOperatorBase<I1, I2, OUT, CoGroupFunction<I1, I2, OUT>>( |
Contributor
There was a problem hiding this comment.
now this line is a bit too long (even if the caret shortcut <> was used)
Contributor
|
+1 to merge. |
Contributor
Author
|
Will rebase it and remove appropriate suppressions first. |
dawidwys
force-pushed
the
checkstyle-java-operators
branch
from
22e4b77 to
20ae6e9
Compare
Contributor
Author
|
merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.
General
Documentation
Tests & Build
mvn clean verifyhas been executed successfully locally or a Travis build has passed