Skip to content

Conversation

@tzulitai
Copy link
Contributor

Backport of #4321 to release-1.3, with the following things being different:

  1. No need to touch KafkaConsumerThread, because in 1.3 the code in KafkaConsumerThread will only ever be reached if there is partitions to subscribe to (therefore would not bump into the changed exception behaviour described in [FLINK-7174] Bump Kafka 0.10 dependency to 0.10.2.1 #4321).
  2. Some touched tests and classes do not exist in 1.3 (e.g. partition reassignment tests, AbstractPartitionDiscoverer) and therefore is not relevant for the backport.

@pnowojski
Copy link
Contributor

Looks good to me.

@tzulitai
Copy link
Contributor Author

Thanks for the review @pnowojski!

I'm also using this branch to collect some final backports for release-1.3. Will merge once Travis is green.

tzulitai added a commit to tzulitai/flink that referenced this pull request Jul 24, 2017
@tzulitai tzulitai closed this Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants