[FLINK-7326] [futures] Replace Flink's future with Java 8's CompletableFuture in RegisteredRpcConnection #4440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zentol
approved these changes
Jul 31, 2017
| } | ||
| }, executor); | ||
|
|
||
| // this future should only ever fail if there is a bug, not if the registration is declined |
Contributor
There was a problem hiding this comment.
We could keep this comment, or is it no longer valid?
Contributor
Author
There was a problem hiding this comment.
True. I will re-add it.
|
|
||
| future.whenCompleteAsync( | ||
| (Tuple2<Gateway, Success> result, Throwable failure) -> { | ||
| if (failure != null) { |
Contributor
There was a problem hiding this comment.
I'm wondering whether we should revert the condition so that the "successful" path comes first.
Contributor
Author
There was a problem hiding this comment.
I somehow like the failure case treating being first. It something like a termination condition for recursion, you also start with it instead of the recursion step.
…mpletableFuture conversion Add DirectExecutionContext Add Scala Future to Java 8 CompletableFuture utility to FutureUtils Add Flink future to Java 8's CompletableFuture conversion utility to FutureUtils Add base class for Flink's unchecked future exceptions
…leFuture in RegisteredRpcConnection
tillrohrmann
force-pushed
the
rfRegisteredRpcConnection
branch
from
f20a4a0 to
918df75
Compare
Contributor
Author
|
Thanks for your review @zentol. Addressed your comment and merging this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Replace Flink's future with Java 8's CompletableFuture in RegisteredRpcConnection.
This PR is based on #4429.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation