[FLINK-7724][REST][Tests][Metrics] add extra metrics to MetricStoreTest.setupStore #4739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Contributor
|
merging. |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Sep 28, 2017
yew1eb
pushed a commit
to yew1eb/flink
that referenced
this pull request
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This is a pre-requisite for FLINK-7694
I'm porting
JobMetricsHandlerto new REST endpoint. Part of the migration is to make sure the json generated before and after stay the same for UI to consume, andJobMetricsHandleris usingMetricStoreTest.setupStore()to get a mockedMetricStore.Here comes the problem. Currently,
MetricStoreTest.setupStore()mocks all jobs with only one metric. We need to have at least one or two jobs with multiple metrics to make the mockedMetricStorecan cover most use cases, and ensure the Json blob generated inJobMetricsHandlerstay the same before and after migration.Brief change log
MetricStoreTest.setupStore()contain multiple metricsVerifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
none
Documentation
none