[FLINK-7708] [flip6] Add CheckpointConfigHandler for new REST endpoint #4744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
portCheckpointConfigHandler
branch
from
76ff833 to
e77fb7a
Compare
zentol
approved these changes
Sep 29, 2017
| public static final String FIELD_NAME_CHECKPOINT_MAX_CONCURRENT = "max_concurrent"; | ||
|
|
||
| public static final String FIELD_NAME_EXTERNALIZED_CHECKPOINT_CONFIG = "externalization"; | ||
|
|
Contributor
There was a problem hiding this comment.
remove empty line (should fail checkstyle)
Contributor
Author
There was a problem hiding this comment.
Thanks for catching it. Will fix it.
…ndlers The ExecutionGraphCache replaces the ExecutionGraphHolder. Unlike the latter, the former does not expect the AccessExecutionGraph to be the true ExecutionGraph. Instead it assumes it to be the ArchivedExecutionGraph. Therefore, it invalidates the cache entries after a given time to live period. This will trigger requesting the AccessExecutionGraph again and, thus, updating the ExecutionGraph information for the ExecutionGraph based REST handlers. In order to avoid memory leaks, the WebRuntimeMonitor starts now a periodic cleanup task which triggers ExecutionGraphCache.cleanup. This methods releases all cache entries which have exceeded their time to live. Currently it is set to 20 * refreshInterval of the web gui. This closes apache#4728.
This commit implements the CheckpointConfigHandler which now returns a CheckpointConfigInfo object if checkpointing is enabled. In case that checkpointing is disabled for a job, it will return a 404 response.
tillrohrmann
force-pushed
the
portCheckpointConfigHandler
branch
from
e77fb7a to
4259fcc
Compare
Contributor
Author
|
Thanks for the review @zentol. Merging this PR once Travis gives green light. |
yew1eb
pushed a commit
to yew1eb/flink
that referenced
this pull request
Oct 4, 2017
This commit implements the CheckpointConfigHandler which now returns a CheckpointConfigInfo object if checkpointing is enabled. In case that checkpointing is disabled for a job, it will return a 404 response. This closes apache#4744.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit implements the CheckpointConfigHandler which now returns a
CheckpointConfigInfo object if checkpointing is enabled. In case that
checkpointing is disabled for a job, it will return a 404 response.
Verifying this change
This change added tests and can be verified as follows:
CheckpointConfigInfoTestchecks the marshalling ofCheckpointConfigInfoDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation