Skip to content

Conversation

@fhueske
Copy link
Contributor

@fhueske fhueske commented Oct 4, 2017

What is the purpose of the change

Fix flink-hbase tests that fail on local builds and pass on Travis.

Brief change log

  • Set root log level of flink-hbase to OFF
  • Log level is changed due to a buggy Calcite check that causes a NPE.
  • The check is only performed if log level DEBUG is enabled.

Verifying this change

  • Tests on flink-hbase pass.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? n/a

Log level is changed due to a buggy Calcite check that causes a NPE.
The check is only performed if log level DEBUG is enabled.
@fhueske
Copy link
Contributor Author

fhueske commented Oct 4, 2017

btw. Calcite fixed the underlying issue in version 1.14 which was release a few days ago.

@zentol
Copy link
Contributor

zentol commented Oct 4, 2017

maybe add a comment to the config file to not set this to debug, otherwise +1.

@StephanEwen
Copy link
Contributor

Will address Zentol's comment and merge. This is blocking me...

@asfgit asfgit closed this in 3a89ab2 Oct 4, 2017
@fhueske fhueske deleted the hbaseTests branch October 4, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants