[FLINK-7766] [FLINK-7767] [file system sink] Cleanups in the streaming FS sinks#4780
Merged
asfgit merged 2 commits intoapache:masterfrom Oct 6, 2017
Merged
[FLINK-7766] [FLINK-7767] [file system sink] Cleanups in the streaming FS sinks#4780asfgit merged 2 commits intoapache:masterfrom
asfgit merged 2 commits intoapache:masterfrom
Conversation
This was done reflectively before for Hadoop 1 compatibility. Since Hadoop 1 is no longer supported, this is obsolete now.
b72eddf to
09a3bf4
Compare
Contributor
|
This LGTM! 👍 I looked at the last two commits here and also the predecessor commits from #4776 |
09a3bf4 to
b62c451
Compare
b62c451 to
bad3df5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This build on top of #4776 - only the last two commits are relevant.
What is the purpose of the change
This change gets rid of some legacy code and improves Hadoop configuration access.
Brief change log
hflush()calls. This was done reflectively before for Hadoop 1 compatibility.Since Hadoop 1 is no longer supported, this is obsolete now.
Verifying this change
This change is already covered by the existing tests for the
BucketingSinkandRollingSink.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation