Skip to content

Conversation

@vim-wj
Copy link

@vim-wj vim-wj commented Oct 20, 2017

SourceFunction extends Function and Serializable, but Function has been extends Serializable, so SourceFunction needn't extends Serializable again.

@vim-wj vim-wj changed the title [Flink] About SourceFunction extends Serializable [FLINK-4877] About SourceFunction extends Serializable Oct 20, 2017
@StephanEwen
Copy link
Contributor

Thanks for opening this pull request.

I think it is correct that SourceFunction is not required to implement Serializable. But I think it does not cause any problems, as far as I know, it has no implication at all on the runtime or behavior.

It does serve as a "reminder" that sources need to be serializable, so it could actually be helpful to keep it.

Given that it makes no difference, should we keep it?

@greghogan
Copy link
Contributor

@vim-wj if you are okay with Stephan's suggestion could you close this pull request?

Also, a small note: FLINK-4877 references a Jira ticket rather than a pull request (use [hotfix] for simple issues not requiring a ticket).

@vim-wj
Copy link
Author

vim-wj commented Nov 22, 2017

@greghogan , @StephanEwen ,sorry fo my late reply.I will close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants