Skip to content

Conversation

@tillrohrmann
Copy link
Contributor

What is the purpose of the change

Makes the MiniClusterConfiguration immutable.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@StephanEwen
Copy link
Contributor

Looks good, +1 to merge this

@tillrohrmann
Copy link
Contributor Author

Thanks for the review @StephanEwen. Merging this PR.

@tillrohrmann tillrohrmann deleted the makeMiniClusterConfigurationImmutable branch October 26, 2017 08:23
asfgit pushed a commit that referenced this pull request Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants