Skip to content

[FLINK-8002] [table] Fix join window boundary for LESS_THAN and GREATER_THAN predicates.#4962

Closed
fhueske wants to merge 1 commit intoapache:masterfrom
fhueske:tableJoinBoundaryFix
Closed

[FLINK-8002] [table] Fix join window boundary for LESS_THAN and GREATER_THAN predicates.#4962
fhueske wants to merge 1 commit intoapache:masterfrom
fhueske:tableJoinBoundaryFix

Conversation

@fhueske
Copy link
Contributor

@fhueske fhueske commented Nov 6, 2017

What is the purpose of the change

Fix the computation of join window boundaries for LESS_THAN and GREATER_THAN predicates if the time attribute of the right input is referenced on the left side of the predicate.

Brief change log

  • check which input is referenced on which side of the predicate to determine whether to add or subtract 1 from the boundary.

Verifying this change

  • JoinTest was extended to verify the computation of the boundaries.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? n/a

@fhueske
Copy link
Contributor Author

fhueske commented Nov 8, 2017

Merging

@asfgit asfgit closed this in 989c779 Nov 8, 2017
asfgit pushed a commit that referenced this pull request Nov 8, 2017
@fhueske fhueske deleted the tableJoinBoundaryFix branch December 12, 2017 21:50
glaksh100 pushed a commit to lyft/flink that referenced this pull request Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants