Skip to content

[Flink 7003] [Table API & SQL] use PEEK_FIELDS_NO_EXPAND for CompositeRelDataType#4989

Closed
suez1224 wants to merge 1 commit intoapache:masterfrom
suez1224:flink-7003
Closed

[Flink 7003] [Table API & SQL] use PEEK_FIELDS_NO_EXPAND for CompositeRelDataType#4989
suez1224 wants to merge 1 commit intoapache:masterfrom
suez1224:flink-7003

Conversation

@suez1224
Copy link
Contributor

@suez1224 suez1224 commented Nov 9, 2017

What is the purpose of the change

This pull request change CompositeRelDataType to use the newly added StructKind PEEK_FIELDS_NO_EXPAND to disable the flattening behavior when select star.

Brief change log

  • Change CompositeRelDataType to use StructKind.PEEK_FIELDS_NO_EXPAND.
  • added unittests for both stream/batch table/SQL APIs.

Verifying this change

This change added unittests for both stream/batch table/SQL APIs to verify the behavior.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): NO
  • The public API, i.e., is any changed class annotated with @Public(Evolving): NO
  • The serializers: NO
  • The runtime per-record code paths (performance sensitive): NO
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: NO
  • The S3 file system connector: NO

Documentation

No

@fhueske
Copy link
Contributor

fhueske commented Nov 9, 2017

Thanks for the PR @suez1224.
I will merge it.

Thanks, Fabian

@twalthr
Copy link
Contributor

twalthr commented Nov 13, 2017

Maybe we can reduce the number of ITCases in this PR and add tests to CompositeAccessTest instead.

@fhueske
Copy link
Contributor

fhueske commented Nov 13, 2017

Yes, I noticed that as well. I tried to add a test to CompositeAccessTest but this doesn't not work with the test base class, because the optimizer removes the Calc node which results in a ClassCastException.

Instead I merged some of the ITCases.

fhueske pushed a commit to fhueske/flink that referenced this pull request Nov 16, 2017
fhueske pushed a commit to fhueske/flink that referenced this pull request Nov 16, 2017
@asfgit asfgit closed this in a63d2be Nov 16, 2017
glaksh100 pushed a commit to lyft/flink that referenced this pull request Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants