[FLINK-6163] Document per-window state in ProcessWindowFunction #4992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpinegizmo
reviewed
Nov 10, 2017
Contributor
alpinegizmo
left a comment
alpinegizmo
left a comment
There was a problem hiding this comment.
I think the terminology needs clarification. Whether it's called per-window state, or "scoped to a window", what's going on remains unclear to someone coming to this unprepared.
It all hinges on what one means by "a window". I may think of my job as having one window -- e.g. an hour-long TimeWIndow. Or I might think that I have 10 windows, because I'm running with a parallelism of 10. Or a million windows because I have a million unique keys. Or that I'll have 24 windows during the course of the day because there will be 24 hour-long windows during a day. Or ...
I'm not sure how best to make things clear, I just know how easy it is to find this confusing.
docs/dev/stream/operators/windows.md
Outdated
| ### Using per-window state in ProcessWindowFunction | ||
|
|
||
| In addition to accessing keyed state (as any rich function can) a `ProcessWindowFunction` can | ||
| also use keyed state that is scoped to the window that the function is currently processing. The are |
Contributor
Author
|
Thanks for the review! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @alpinegizmo