[FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase#5066
Closed
NicoK wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase#5066NicoK wants to merge 1 commit intoapache:masterfrom
NicoK wants to merge 1 commit intoapache:masterfrom
Conversation
Remove a check for a deleted directory since we may not see our own delete yet with S3.
Contributor
|
Makes sense, +1 |
Contributor
|
merging. |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Nov 29, 2017
Remove a check for a deleted directory since we may not see our own delete yet with S3. This closes apache#5066.
Contributor
|
will fix the checkstyle violation on the way. |
Contributor
Author
|
oh, sorry for that |
zentol
pushed a commit
to zentol/flink
that referenced
this pull request
Dec 4, 2017
Remove a check for a deleted directory since we may not see our own delete yet with S3. This closes apache#5066.
asfgit
pushed a commit
that referenced
this pull request
Dec 4, 2017
Remove a check for a deleted directory since we may not see our own delete yet with S3. This closes #5066.
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 6, 2018
Remove a check for a deleted directory since we may not see our own delete yet with S3. This closes apache#5066.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
YarnFileStageTestS3ITCase.testRecursiveUploadForYarnverifies that the test directory used is cleaned up byYarnFileStageTest.testCopyFromLocalRecursivewhich should clean up the directory (in afinallyblock). However, for S3, we may not always see our own deletes.Quoting from https://aws.amazon.com/s3/faqs/ here:
Brief change log
with S3.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation