[FLINK-8216] [Kinesis connector] Unify test utils in flink-connector-kinesis #5130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzulitai
approved these changes
Dec 7, 2017
| /** | ||
| * Get properties with Kinesis-required fields. | ||
| */ | ||
| public static Properties getPropertiesWithRequiredFields() { |
Contributor
There was a problem hiding this comment.
I prefer the name getStandardProperties over this one. That makes it a bit more coherent with the Kafka test code.
bowenli86
changed the title
Contributor
|
Merging this .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
currently there are a few ways to get a
Propertiesobject with required fields (aws access key, aws secret key, aws region) forKinesisConsumerandKinesisProducerin unit tests. We should unify them and provide a single util to get thatPropertiesobjectBrief change log
Unified all similar test utils to
TestUtils.getPropertiesWithRequiredFields()Verifying this change
This change is already covered by existing tests in
flink-connector-kinesisDoes this pull request potentially affect one of the following parts:
none
Documentation
none