Skip to content

Conversation

@eskabetxe
Copy link
Member

What is the purpose of the change

solve the issue related, adding aws region to kinesis producer configuration

Verifying this change

This change added tests and can be verified as follows:

  • Added test that validates that region is correctly setted

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)

@eskabetxe eskabetxe changed the base branch from master to release-1.4 December 13, 2017 11:19
@tzulitai
Copy link
Contributor

Thanks for the fix @eskabetxe.
Can you squash commits fd9395f and 170372a, and rebase them onto latest release-1.4 branch?

@eskabetxe
Copy link
Member Author

@tzulitai done on #5160

this could be closed

@tzulitai
Copy link
Contributor

Thanks. @eskabetxe can you manually close this? Only the issuer of the PR can close it :)

@eskabetxe eskabetxe closed this Dec 13, 2017
@eskabetxe
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants