Skip to content

Conversation

@yew1eb
Copy link
Contributor

@yew1eb yew1eb commented Dec 28, 2017

What is the purpose of the change

  1. Fix typo of Threads.Count metric in docs.
  2. Fix Liquid Exception: highlight tag was never closed in monitoring/metrics.md by removing unnecessary {% highlight java %} Liquid tag.

@yew1eb yew1eb changed the title [docs][metrics] Fix typo of metrics docs [Minor][docs][metrics] Fix typo of metrics docs Dec 28, 2017
<tr>
<th rowspan="1"><strong>Job-/TaskManager</strong></th>
<td rowspan="1">Status.JVM.ClassLoader</td>
<td rowspan="1">Status.JVM</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infix as Status.JVM.Threads and Metrics as Count?

@yew1eb yew1eb force-pushed the fix_docs_metric_threads_count branch from 2f056b0 to 8c32a94 Compare January 4, 2018 00:58
@zentol
Copy link
Contributor

zentol commented Jan 8, 2018

merging.

zentol pushed a commit to zentol/flink that referenced this pull request Jan 8, 2018
zentol pushed a commit to zentol/flink that referenced this pull request Jan 8, 2018
@asfgit asfgit closed this in a31e8a3 Jan 8, 2018
zentol pushed a commit to zentol/flink that referenced this pull request Jan 8, 2018
@yew1eb yew1eb deleted the fix_docs_metric_threads_count branch January 25, 2018 12:11
glaksh100 pushed a commit to lyft/flink that referenced this pull request Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants