Closed
Conversation
Fix typos from the IntelliJ "Typos" inspection.
fhueske
approved these changes
Jan 5, 2018
Contributor
fhueske
left a comment
fhueske
left a comment
There was a problem hiding this comment.
Wow, thanks for fixing all these typos @greghogan!
The one line I commented on can be deleted.
+1 to merge
|
|
||
| val selectedFields = if (fields.isEmpty) Array(0) else fields | ||
| // val selectedFiels = fields | ||
| // val selectedFields = fields |
Contributor
|
Wow, this is pretty good! Thanks a lot! Addressing Fabian's comment and merging this. Want that merged very soon to avoid future merge conflicts... |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Jan 5, 2018
Fix typos from the IntelliJ "Typos" inspection. This closes apache#5242
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Jan 5, 2018
Fix typos from the IntelliJ "Typos" inspection. This closes apache#5242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix typos from the IntelliJ "Typos" inspection. I have tried to preserve British vs American English spellings. IntelliJ is adamant about reordering imports in two files.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation