Flink-1780: Rename FlatCombineFunction to GroupCombineFunction #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@smarthi Thanks for the PR! |
Member
Author
|
@fhueske yeah noticed that too, will update the PR |
Member
Author
|
@fhueske i think we shuld be LGTM now |
Contributor
There was a problem hiding this comment.
Not sure if this change improves the readability of the code.
Member
Author
There was a problem hiding this comment.
Agreed. please feel free to revert this change.
Contributor
|
+1 This rename makes a lot of sense. Looks good to me apart from the minor comments. |
Contributor
|
The documentation also needs to be adapted to use the new interface name. @smarthi If you don't mind I will merge your commit with my remarks addressed. |
Member
Author
|
@mxm please go ahead |
Contributor
|
Thank you for the pull request! |
bhatsachin
pushed a commit
to bhatsachin/flink
that referenced
this pull request
May 5, 2015
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Flink-1780