[FLINK-7095] [TaskManager] Add Command line parsing tool to TaskManag…

[rice668]

What is the purpose of the change

Add a proper command line parsing tool to the entry point of the TaskManagerRunner#main.

Brief change log

• Use Commons CLI as tool to implement this functionality.
• Remove the original way of ParameterTool.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (don't know)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (yes)
• If yes, how is the feature documented? (JavaDocs)

[tillrohrmann]

Thanks for your contribution @zhangminglei. I think you have to revisit which options are registered in order to parse the configDir parameter. Please also write a test to verify your changes.

[tillrohrmann]

Have you tried whether this actually works? It looks to me as if this will always return null. Please write a test for it.

[rice668]

Thanks @tillrohrmann . I will take a look based on your suggestions.

[rice668]

@tillrohrmann It seems that now there is not any Option be registered for later parse the configDir parameter I just checked. I either register the configDir parameter in somewhere, such as in CliFrontendParser class or directly use TaskManager.parseArgsAndLoadConfig(args); to get Configuration. What do you think of this ? @tillrohrmann Thanks.

[rice668]

I have updated the code and write a test. @tillrohrmann Thanks in advance to review those codes ~

[tillrohrmann]

Sorry for not getting back to you earlier @zhangminglei. I accidentally addressed this issue with #6318. I think we can therefore close this PR.

Sorry for the bad PR management. This won't happen again.

[rice668]

Hi, @tillrohrmann . You are welcome ~ I still have a lot of other flink jira will be addressed by me in the future.