[FLINK-8559][RocksDB] Release resources if snapshot operation fails#5412
Closed
zentol wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-8559][RocksDB] Release resources if snapshot operation fails#5412zentol wants to merge 1 commit intoapache:masterfrom
zentol wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
LGTM |
Contributor
Author
|
merging. |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Feb 5, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Feb 5, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Feb 6, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Feb 6, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Feb 6, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Feb 6, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Feb 6, 2018
JTaky
pushed a commit
to criteo-forks/flink
that referenced
this pull request
Feb 16, 2018
glaksh100
pushed a commit
to lyft/flink
that referenced
this pull request
Jun 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR ensures that RocksDB resources are released if
RocksDBIncrementalSnapshotOperation#takeSnapshotthrows an Exception.We now catch the exception, cancel the SnapshotOperation, and re-throw the original exception.
Verifying this change
I've verified this manually by running
JobManagerHACheckpointRecoveryITCaseon Windows wheretakeSnapshotfails due to FLINK-8557.I couldn't come up with proper test. The method hardly does anything in the first place and every solution i could think of would depend a lot on implementation details (like mocking
Checkpoint.create()to throw an exception).Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
@StefanRRichter