Skip to content

[FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint #5429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tillrohrmann wants to merge 2 commits into from
Closed

[FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint #5429

tillrohrmann wants to merge 2 commits into from

Conversation

@tillrohrmann
Copy link
Contributor

@tillrohrmann tillrohrmann commented Feb 8, 2018

What is the purpose of the change

Register the JobTerminationHandler at the WebMonitorEndpoint to make it accessible to
all REST endpoints.

Verifying this change

  • Tested manually

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@tillrohrmann tillrohrmann mentioned this pull request Feb 8, 2018
Closed
@tillrohrmann tillrohrmann force-pushed the moveTerminationHandler branch from f906423 to 87cdb48 Compare February 8, 2018 16:04
@tillrohrmann
[hotfix] Change shutdown order in WebMonitorEndpoint to avoid illegal…
82e5d0c 
… state
@tillrohrmann
[FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint
5450620 
Register the JobTerminationHandler at the WebMonitorEndpoint to make it accessible to
all REST endpoints.
@tillrohrmann tillrohrmann force-pushed the moveTerminationHandler branch from 87cdb48 to 5450620 Compare February 10, 2018 22:18
@tillrohrmann
Copy link
Contributor Author

tillrohrmann commented Feb 14, 2018

Merging this PR.

tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Feb 14, 2018
@tillrohrmann
[FLINK-8604] [rest] Move JobTerminationHandler into WebMonitorEndpoint
da5f4ce 
Register the JobTerminationHandler at the WebMonitorEndpoint to make it accessible to
all REST endpoints.

This closes apache#5429.
@asfgit asfgit closed this in a510589 Feb 15, 2018
@tillrohrmann tillrohrmann deleted the moveTerminationHandler branch February 15, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GJL GJL GJL approved these changes

Assignees

No one assigned

Labels

component=Runtime/REST

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tillrohrmann @GJL @rmetzger