Skip to content

Conversation

@tillrohrmann
Copy link
Contributor

What is the purpose of the change

The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended but its
clean up has not been done yet. Only after all Executions have been canceled, the
ExecutionGraph will enter the SUSPENDED state and complete the termination future
accordingly.

Brief change log

  • Rename JobStatus#SUSPENDED into JobStatus#SUSPENDING
  • Introduce new JobStatus#SUSPENDED
  • Only go into JobStatus#SUSPENDED from JobStatus#SUSPENDING once we have cancelled all Executions

Verifying this change

  • Updated ExecutionGraphSuspendTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended but its
clean up has not been done yet. Only after all Executions have been canceled, the
ExecutionGraph will enter the SUSPENDED state and complete the termination future
accordingly.

This closes apache#5445.
@tillrohrmann tillrohrmann force-pushed the executionGraphTerminationFuture branch from 303c053 to efbf9b8 Compare February 19, 2018 10:08
tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Feb 19, 2018
The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended but its
clean up has not been done yet. Only after all Executions have been canceled, the
ExecutionGraph will enter the SUSPENDED state and complete the termination future
accordingly.

This closes apache#5445.
tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Feb 19, 2018
The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended but its
clean up has not been done yet. Only after all Executions have been canceled, the
ExecutionGraph will enter the SUSPENDED state and complete the termination future
accordingly.

This closes apache#5445.
tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Feb 19, 2018
The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended but its
clean up has not been done yet. Only after all Executions have been canceled, the
ExecutionGraph will enter the SUSPENDED state and complete the termination future
accordingly.

This closes apache#5445.
tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Feb 20, 2018
The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended but its
clean up has not been done yet. Only after all Executions have been canceled, the
ExecutionGraph will enter the SUSPENDED state and complete the termination future
accordingly.

This closes apache#5445.
tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Feb 21, 2018
The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended but its
clean up has not been done yet. Only after all Executions have been canceled, the
ExecutionGraph will enter the SUSPENDED state and complete the termination future
accordingly.

This closes apache#5445.
tillrohrmann added a commit to tillrohrmann/flink that referenced this pull request Feb 22, 2018
The new JobStatus#SUSPENDING says that an ExecutionGraph has been suspended but its
clean up has not been done yet. Only after all Executions have been canceled, the
ExecutionGraph will enter the SUSPENDED state and complete the termination future
accordingly.

This closes apache#5445.
@asfgit asfgit closed this in 7e96a24 Feb 23, 2018
@tillrohrmann tillrohrmann deleted the executionGraphTerminationFuture branch February 24, 2018 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants