[FLINK-1805]The class IOManagerAsync should use its own Log instance#546
Closed
matadorhong wants to merge 2 commits intoapache:masterfrom
Closed
[FLINK-1805]The class IOManagerAsync should use its own Log instance#546matadorhong wants to merge 2 commits intoapache:masterfrom
matadorhong wants to merge 2 commits intoapache:masterfrom
Conversation
…r) should use its own Log instance
matadorhong
changed the title
Contributor
There was a problem hiding this comment.
Could we just use private here instead of protected?
Contributor
Author
There was a problem hiding this comment.
@hsaputra Yes, private here is better. Thanks you. I have updated it.
Contributor
|
+1 LGTM Once Travis done will merge unless more review coming in. Thanks! |
bhatsachin
pushed a commit
to bhatsachin/flink
that referenced
this pull request
May 5, 2015
Although class 'IOManagerAsync' is extended from 'IOManager' in package 'org.apache.flink.runtime.io.disk.iomanager', but I think it should has its own Log instance. Author: hongsibao <hongsibao@huawei.com> Closes apache#546 from matadorhong/FLINK-1805 and squashes the following commits: 89c0dd7 [hongsibao] Use private instead of protected 56b9dab [hongsibao] The class IOManagerAsync(in org.apache.flink.runtime.io.disk.iomanager) should use its own Log instance
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
Although class 'IOManagerAsync' is extended from 'IOManager' in package 'org.apache.flink.runtime.io.disk.iomanager', but I think it should has its own Log instance. Author: hongsibao <hongsibao@huawei.com> Closes apache#546 from matadorhong/FLINK-1805 and squashes the following commits: 89c0dd7 [hongsibao] Use private instead of protected 56b9dab [hongsibao] The class IOManagerAsync(in org.apache.flink.runtime.io.disk.iomanager) should use its own Log instance
pnowojski
pushed a commit
to pnowojski/flink
that referenced
this pull request
Mar 8, 2024
* [hotfix] Fixes bug with no-arg UDF calls * Adds plugin version id * Style again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although class 'IOManagerAsync' is extended from 'IOManager' in package 'org.apache.flink.runtime.io.disk.iomanager', but I think it should has its own Log instance.