[FLINK-8621][prometheus][tests] Remove endpointIsUnavailableAfterReporterIsClosed() #5473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rterIsClosed() The test is inherently unstable as it will always fail if any other server is started on the port between the closing of the reporter and the polling of metrics.
…aultRegistry It appeared as if the HTTPServer wasn't actually doing anything, but it internally accessed the singleton registry that we also access to register metrics.
kl0u
approved these changes
Feb 19, 2018
| * @return next port range | ||
| */ | ||
| public synchronized String next() { | ||
| if (!hasNext()) { |
Contributor
There was a problem hiding this comment.
I think the synchronized here is not needed as there does not seem to be any concurrent access.
asfgit
pushed a commit
that referenced
this pull request
Feb 20, 2018
…rterIsClosed() The test is inherently unstable as it will always fail if any other server is started on the port between the closing of the reporter and the polling of metrics. This closes #5473.
kbialek
pushed a commit
to kbialek/flink
that referenced
this pull request
Feb 23, 2018
…rterIsClosed() The test is inherently unstable as it will always fail if any other server is started on the port between the closing of the reporter and the polling of metrics. This closes apache#5473.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR removes an unstable test for the PrometheusReporter. The test verified that the metrics could no longer be polled when the reporter was shutdown, however if any other process were to start a server on the same port (which is free after the reporter shutdown) the test would fail.
We could theoretically check in that case that it wasn't our reporter that responded, but that's a bit tricky to do with how the reporter currently works (singleton registry).
This PR also contains 2 minor changes:
HTTPServeris used