Skip to content

Conversation

@sihuazhou
Copy link
Contributor

This PR fix FLINK-8699. In fully checkpoint, kvStateInformation is not a copied object and it can be changed when writeKVStateMetaData() is invoking ... This can lead to problematic, which is serious.

Brief change log

  • Copy kvStateInformation to avoid concurrency problem.

Verifying this change

  • This change can be verified by the existed unit tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@sihuazhou
Copy link
Contributor Author

@StefanRRichter Could you please have a look?

@sihuazhou sihuazhou closed this Feb 19, 2018
Copy link
Contributor

@StefanRRichter StefanRRichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sihuazhou sihuazhou deleted the hotfix_full_checkpoint branch June 7, 2018 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants