[FLINK-8730][REST] JSON serialize entire SerializedThrowable #5546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not only serialize the serialized exception but the entire SerializedThrowable object. This makes it possible to throw the SerializedThrowable itself without deserializing it.
| /** | ||
| * Tests for {@link SerializedThrowableSerializer} and {@link SerializedThrowableDeserializer}. | ||
| */ | ||
| public class SerializedThrowableSerializerTest { |
tillrohrmann
approved these changes
Feb 28, 2018
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for the contribution @GJL. Changes look good to me. Merging this PR.
tillrohrmann
pushed a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 28, 2018
Do not only serialize the serialized exception but the entire SerializedThrowable object. This makes it possible to throw the SerializedThrowable itself without deserializing it. This closes apache#5546.
tillrohrmann
pushed a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 28, 2018
Do not only serialize the serialized exception but the entire SerializedThrowable object. This makes it possible to throw the SerializedThrowable itself without deserializing it. This closes apache#5546.
asfgit
pushed a commit
that referenced
this pull request
Feb 28, 2018
Do not only serialize the serialized exception but the entire SerializedThrowable object. This makes it possible to throw the SerializedThrowable itself without deserializing it. This closes #5546.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
For the JSON representation, do not only serialize the serialized exception but the entire SerializedThrowable object. This makes it possible to throw the SerializedThrowable itself without deserializing it.
cc: @tillrohrmann
Brief change log
Verifying this change
This change added tests and can be verified as follows:
SerializedThrowableSerializer. Previously, onlyJobExecutionResultResponseBodyTestcovered it.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation