[FLINK-8773] [flip6] Make JobManagerRunner shut down non blocking #5575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
nonBlockingJobManagerRunner
branch
from
4a0735b to
9836df1
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 24, 2018
The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion. Instead it registers the termination futures and calls the shut down of the JobManagerSharedServices once all JobManagerRunners have terminated. This closes apache#5575.
The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion. Instead it registers the termination futures and calls the shut down of the JobManagerSharedServices once all JobManagerRunners have terminated. This closes apache#5575.
tillrohrmann
force-pushed
the
nonBlockingJobManagerRunner
branch
from
9836df1 to
2c40697
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The Dispatcher no longer shuts down the JobManagerRunner in a blocking fashion.
Instead it registers the termination futures and calls the shut down of the
JobManagerSharedServices once all JobManagerRunners have terminated.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation