[FLINK-8557][checkpointing] Remove illegal characters from operator d… #5598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…escription text before using it to construct the instance directory in RocksDB
Contributor
Author
|
Thanks @zentol for the fast review! Will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This fixes the problem that the operator descriptor text is used to construct the instance directory in RocksDB, but can contain characters that are illegal for paths in some file systems.
Brief change log
We replace all illegal characters with underscore before constructing the path.
Verifying this change
Check if RocksDB can be used as state backend on Windows.
This change is a trivial rework / code cleanup without any test coverage.