[FLINK-8808] [flip6] Allow RestClusterClient to connect to local dispatcher #5599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atcher The RestClusterClient resolves a dispatcher address without an explicit host to 'localhost'. That way we allow the RestClusterClient to talk to a Dispatcher which runs in a local ActorSystem.
|
I watched the code and think it is very good. But the travis says |
Contributor
|
+1 to merge this 👌 |
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Mar 1, 2018
…atcher The RestClusterClient resolves a dispatcher address without an explicit host to 'localhost'. That way we allow the RestClusterClient to talk to a Dispatcher which runs in a local ActorSystem. This closes apache#5599.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Mar 1, 2018
…atcher The RestClusterClient resolves a dispatcher address without an explicit host to 'localhost'. That way we allow the RestClusterClient to talk to a Dispatcher which runs in a local ActorSystem. This closes apache#5599.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Mar 1, 2018
…atcher The RestClusterClient resolves a dispatcher address without an explicit host to 'localhost'. That way we allow the RestClusterClient to talk to a Dispatcher which runs in a local ActorSystem. This closes apache#5599.
asfgit
pushed a commit
that referenced
this pull request
Mar 2, 2018
…atcher The RestClusterClient resolves a dispatcher address without an explicit host to 'localhost'. That way we allow the RestClusterClient to talk to a Dispatcher which runs in a local ActorSystem. This closes #5599.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The RestClusterClient resolves a dispatcher address without an explicit host
to 'localhost'. That way we allow the RestClusterClient to talk to a Dispatcher
which runs in a local ActorSystem.
cc: @aljoscha
Verifying this change
ScalaUtilsTest#testOptionToOptionalDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation