Skip to content

Conversation

@yanghua
Copy link
Contributor

@yanghua yanghua commented Mar 28, 2018

What is the purpose of the change

This pull request fixed unintended integer division in StandaloneThreadedGenerator

Brief change log

  • Fixed unintended integer division in StandaloneThreadedGenerator

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@yanghua
Copy link
Contributor Author

yanghua commented Mar 28, 2018

cc @tillrohrmann

@greghogan
Copy link
Contributor

LGTM but I'd cc @StephanEwen since the code looks to have been ported recently.

@StephanEwen
Copy link
Contributor

Looks good, +1 to merge

@StephanEwen
Copy link
Contributor

Thanks, merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Mar 29, 2018
@asfgit asfgit closed this in 98924f0 Mar 29, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants