Skip to content

Conversation

@yuqi1129
Copy link
Contributor

@yuqi1129 yuqi1129 commented Apr 9, 2018

What is the purpose of the change

This pull request makes the jobmanager return specific information if there is not enough sloth available when flink dataset job request for resources. Now, flink only return AskTimeoutException cause by timeout.

Brief change log

  • Change kind of exception caused by allocation timeout when submitting dataset job to jobmanager in local mode.

Verifying this change

This change added tests and can be verified as follows:

  • Add test ExecutionVertexSchedulingTest.testScheduleToDeployingAndTestTimeOutException

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@yuqi1129
Copy link
Contributor Author

@tillrohrmann Could you help to check if this change is acceptable ?

@zentol
Copy link
Contributor

zentol commented Nov 19, 2018

This issue has been fixed in FLINK-10883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants