[FLINK-9156][REST][CLI] Update --jobmanager option logic for REST client#5838
Closed
zentol wants to merge 2 commits intoapache:masterfrom
Closed
[FLINK-9156][REST][CLI] Update --jobmanager option logic for REST client#5838zentol wants to merge 2 commits intoapache:masterfrom
zentol wants to merge 2 commits intoapache:masterfrom
Conversation
GJL
approved these changes
Apr 12, 2018
|
|
||
| URL webMonitorBaseUrl = clusterClient.getWebMonitorBaseUrl().get(); | ||
| assertThat(webMonitorBaseUrl.getHost(), Matchers.equalTo(manualHostname)); | ||
| assertThat(webMonitorBaseUrl.getPort(), Matchers.equalTo(manualPort)); |
Member
There was a problem hiding this comment.
There is already a static import for equalTo in this file. I think it should be used, i.e.,
assertThat(webMonitorBaseUrl.getHost(), equalTo(manualHostname));
assertThat(webMonitorBaseUrl.getPort(), equalTo(manualPort));
| */ | ||
| @Test | ||
| public void testRESTManualConfigurationOverride() throws Exception { | ||
| final String localhost = "localhost"; |
Member
There was a problem hiding this comment.
Maybe configuredHostname, to be consistent with manualHostname. localhost is an arbitrary value, and should not be the name of the variable.
Contributor
Author
|
merging. |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Apr 16, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
Apr 16, 2018
asfgit
pushed a commit
that referenced
this pull request
Apr 16, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is the purpose of the change
With this PR the
--jobmanageroption is properly respected by theRestClusterClient. The problem was that the existing code was only settingJobManagerOptions.ADDRESSandJobManagerOptions.PORT, but not the correspondingRestOptionsthat are used for all REST API calls. TheRestOptionsare accessed inHighAvailabilityServicesUtils#createHighAvailabilityServicesto create the webmonitor URL that is used by the client.Brief change log
CliFrontend#setJobManagerAddressInConfigVerifying this change
RestClusterClientTest#testRESTManualConfigurationOverrideDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation