[FLINK-9076][network] reduce minimum number of floating buffers to 0 #5874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Currently, floating buffers (per gate) are always required in case credit-based flow control is enabled. This, however, increases our minimum number of required network buffers.
Instead, we should also work with a minimum of zero floating buffers and set the max to the configured value. This way, if there are not enough buffers, all
LocalBufferPools will at least share the available ones and not fail the job.Brief change log
extraNetworkBuffersPerGatebuffers, depending on availability) - this is similar to the non-credit based code pathtaskmanager.network.memory.buffers-per-channelin this regardVerifying this change
This change added tests and can be verified as follows:
NetworkEnvironmentTestto cover minimum and insufficient buffers scenarios for both credit-based and non-credit basedStreamNetworkThroughputBenchmarkTestcovering minimum and insufficient buffers scenarios for default, i.e. credit-based, flow controlDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation