[FLINK-1891]Add the input storageDirectory empty check#601
Closed
matadorhong wants to merge 2 commits intoapache:masterfrom
Closed
[FLINK-1891]Add the input storageDirectory empty check#601matadorhong wants to merge 2 commits intoapache:masterfrom
matadorhong wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
can you change storageDirectory.isEmpty() to storageDirectory.trim().isEmpty() to remove all whitespaces before the empty-check?
Contributor
Author
There was a problem hiding this comment.
Yeah, you are right. Thank for you notes.I have change it.
Contributor
|
Thanks for the PR. |
Contributor
|
I'm going to merge this PR. |
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Apr 21, 2015
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Apr 21, 2015
thvasilo
pushed a commit
to thvasilo/flink
that referenced
this pull request
Apr 24, 2015
bhatsachin
pushed a commit
to bhatsachin/flink
that referenced
this pull request
May 5, 2015
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
pnowojski
pushed a commit
to pnowojski/flink
that referenced
this pull request
Mar 8, 2024
Merge branch 'apache-release-1.18' into release-1.18-confluent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the input storageDirectory empty check, if input of storageDirectory is empty, we should use tmp as the base dir
And also fix the code style proble of blank space between every ) and {