[FLINK-1909] [streaming] Type handling refactor for sources + scala api#610
Closed
gyfora wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-1909] [streaming] Type handling refactor for sources + scala api#610gyfora wants to merge 1 commit intoapache:masterfrom
gyfora wants to merge 1 commit intoapache:masterfrom
Conversation
gyfora
force-pushed
the
FLINK-1909
branch
3 times, most recently
from
6083f82 to
a57ab79
Compare
Contributor
|
LGTM. |
Contributor
There was a problem hiding this comment.
Why did you change this?
I suspect the exception will now be thrown somewhere else?
Contributor
Author
There was a problem hiding this comment.
This is the same mechanism that all flink operators use to allow missing types that can be filled with .returns(..) afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks the way sources handle type extraction, allowing for missing types (with returns) and also fixes some issues around type handling for the streaming Scala api.