[FLINK-9672] Fail fatally if job submission fails on added JobGraph signal #6213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GJL
reviewed
Jun 28, 2018
|
|
||
| @Override | ||
| public CompletableFuture<Collection<JobID>> listJobs(Time timeout) { | ||
| if (jobManagerRunners.isEmpty()) { |
GJL
approved these changes
Jun 29, 2018
Contributor
Author
|
Thanks for the review @GJL. Merging this PR into master and |
tillrohrmann
force-pushed
the
hardenOnAddedJobGraph
branch
from
2d5835f to
2be3b0e
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Jun 29, 2018
…ignal This closes apache#6213.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Jun 29, 2018
…ignal This closes apache#6213.
tillrohrmann
force-pushed
the
hardenOnAddedJobGraph
branch
from
2be3b0e to
7b4cb52
Compare
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…ignal This closes apache#6213.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fail fatally if we cannot recover the job on the
onAddedJobGraphsignal from theSubmittedJobGraphListener.Verifying this change
DispatcherTest#testOnAddedJobGraphRecoveryFailureandDispatcherTest#testOnAddedJobGraphWithFinishedJobDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation