[FLINK-9695] [mesos] Add option for Mesos executor to forcefully pull Docker images #6232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
requested changes
Jun 30, 2018
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for opening this PR @lishim. I had a comment concerning the name of the config option. Apart from that, the PR looks good and can be merged after addressing the comment.
| " Comma separated list of \"key=value\" pairs. The \"value\" may contain '='."); | ||
|
|
||
| public static final ConfigOption<Boolean> MESOS_RM_CONTAINER_DOCKER_FORCE_PULL_IMAGE = | ||
| key("mesos.resourcemanager.tasks.container.docker.forcePullImage") |
Contributor
There was a problem hiding this comment.
In order to make it consistent with other configuration options, we should name this config option force-pull-image.
lishim
force-pushed
the
feature/forcePullImage
branch
from
2e6274b to
b3264f4
Compare
…-pull-image option
lishim
force-pushed
the
feature/forcePullImage
branch
from
b3264f4 to
a5eb20b
Compare
Contributor
Author
|
Hi @tillrohrmann. Thank you for your comment. I have updated the code to conform to other configuration options. |
tillrohrmann
approved these changes
Jul 3, 2018
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments @lishim. LGTM. Merging this PR.
tillrohrmann
pushed a commit
to tillrohrmann/flink
that referenced
this pull request
Jul 3, 2018
…-pull-image option This closes apache#6232.
Xeli
pushed a commit
to Xeli/flink
that referenced
this pull request
Jul 17, 2018
…-pull-image option This closes apache#6232.
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…-pull-image option This closes apache#6232.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief change log
mesos.resourcemanager.tasks.container.docker.force-pull-imagewas introducedVerifying this change
This change added tests and can be verified as follows:
mesos.resourcemanager.tasks.container.docker.force-pull-imagewas left out or set tofalse. Confirmed that fresh image was pulled and used over a cached image whenmesos.resourcemanager.tasks.container.docker.force-pull-imagewas set totrue.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation